lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <YgxiBO7jDtyhWwlb@google.com> Date: Wed, 16 Feb 2022 10:31:32 +0800 From: Tzung-Bi Shih <tzungbi@...gle.com> To: Prashant Malani <pmalani@...omium.org> Cc: bleung@...omium.org, groeck@...omium.org, robh+dt@...nel.org, chrome-platform@...ts.linux.dev, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 4/5] platform/chrome: cros_kbd_led_backlight: support OF match On Tue, Feb 15, 2022 at 05:10:04PM -0800, Prashant Malani wrote: > On Sun, Feb 13, 2022 at 9:37 PM Tzung-Bi Shih <tzungbi@...gle.com> wrote: > > diff --git a/drivers/platform/chrome/cros_kbd_led_backlight.c b/drivers/platform/chrome/cros_kbd_led_backlight.c > > index 814f2b74c602..ba853e55d29a 100644 > > --- a/drivers/platform/chrome/cros_kbd_led_backlight.c > > +++ b/drivers/platform/chrome/cros_kbd_led_backlight.c > > @@ -10,6 +10,7 @@ > > #include <linux/kernel.h> > > #include <linux/leds.h> > > #include <linux/module.h> > > +#include <linux/of_device.h> > > #include <linux/platform_device.h> > > #include <linux/slab.h> > > > > @@ -128,8 +129,11 @@ static int keyboard_led_probe(struct platform_device *pdev) > > int error; > > > > drvdata = acpi_device_get_match_data(&pdev->dev); > > - if (!drvdata) > > - return -EINVAL; > > + if (!drvdata) { > > + drvdata = of_device_get_match_data(&pdev->dev); > > + if (!drvdata) > > + return -EINVAL; > > + } > > I'm not familiar with this driver, so can't do a full review, but > shouldn't device_get_match_data() > from property.h [1] be able to handle both DT and ACPI cases? > > [1]: https://elixir.bootlin.com/linux/v5.17-rc4/source/include/linux/property.h Yes, it does[2][3]. Thanks for the feedback, will fix it in next version. [2]: https://elixir.bootlin.com/linux/v5.17-rc4/source/drivers/of/property.c#L1474 [3]: https://elixir.bootlin.com/linux/v5.17-rc4/source/drivers/acpi/property.c#L1386
Powered by blists - more mailing lists