linux-kernel - Re: [PATCH v3 0/5] linkage: better symbol aliasing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220216060038.s2ymjrfghokzmwp4@treble>
Date:   Tue, 15 Feb 2022 22:00:38 -0800
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Mark Rutland <mark.rutland@....com>
Cc:     linux-kernel@...r.kernel.org, acme@...hat.com, ardb@...nel.org,
        bp@...en8.de, broonie@...nel.org, catalin.marinas@....com,
        dave.hansen@...ux.intel.com, jslaby@...e.cz,
        linux-arm-kernel@...ts.infradead.org, mingo@...hat.com,
        ndesaulniers@...gle.com, peterz@...radead.org, tglx@...utronix.de,
        will@...nel.org
Subject: Re: [PATCH v3 0/5] linkage: better symbol aliasing

On Fri, Feb 11, 2022 at 03:14:40PM +0000, Mark Rutland wrote:
> This series aims to make symbol aliasing simpler and more consistent.
> The basic idea is to replace SYM_FUNC_START_ALIAS(alias) and
> SYM_FUNC_END_ALIAS(alias) with a new SYM_FUNC_ALIAS(alias, name), so
> that e.g.
> 
>     SYM_FUNC_START(func)
>     SYM_FUNC_START_ALIAS(alias1)
>     SYM_FUNC_START_ALIAS(alias2)
>         ... asm insns ...
>     SYM_FUNC_END(func)
>     SYM_FUNC_END_ALIAS(alias1)
>     SYM_FUNC_END_ALIAS(alias2)
>     EXPORT_SYMBOL(alias1)
>     EXPORT_SYMBOL(alias2)
> 
> ... can become:
> 
>     SYM_FUNC_START(name)
>         ... asm insns ...
>     SYM_FUNC_END(name)
> 
>     SYM_FUNC_ALIAS(alias1, func)
>     EXPORT_SYMBOL(alias1)
> 
>     SYM_FUNC_ALIAS(alias2, func)
>     EXPORT_SYMBOL(alias2)
> 
> This avoids repetition and hopefully make it easier to ensure
> consistency (e.g. so each function has a single canonical name and
> associated metadata).

Nice!

Other than the minor comment to squash the synced header changes,

Acked-by: Josh Poimboeuf <jpoimboe@...hat.com>

-- 
Josh