linux-kernel - Re: [PATCH v3 5/5] tools: update x86 string routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yg0G/nr0D2KXHuwA@lakrids>
Date:   Wed, 16 Feb 2022 14:15:26 +0000
From:   Mark Rutland <mark.rutland@....com>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     linux-kernel@...r.kernel.org, acme@...hat.com, ardb@...nel.org,
        bp@...en8.de, broonie@...nel.org, catalin.marinas@....com,
        dave.hansen@...ux.intel.com, jslaby@...e.cz,
        linux-arm-kernel@...ts.infradead.org, mingo@...hat.com,
        ndesaulniers@...gle.com, peterz@...radead.org, tglx@...utronix.de,
        will@...nel.org
Subject: Re: [PATCH v3 5/5] tools: update x86 string routines

On Tue, Feb 15, 2022 at 09:59:52PM -0800, Josh Poimboeuf wrote:
> On Fri, Feb 11, 2022 at 03:14:45PM +0000, Mark Rutland wrote:
> > When building the perf tool the build system complains that the x86
> > string routines are out-of-date:
> > 
> > | Warning: Kernel ABI header at 'tools/arch/x86/lib/memcpy_64.S' differs from latest version at 'arch/x86/lib/memcpy_64.S'
> > | diff -u tools/arch/x86/lib/memcpy_64.S arch/x86/lib/memcpy_64.S
> > | Warning: Kernel ABI header at 'tools/arch/x86/lib/memset_64.S' differs from latest version at 'arch/x86/lib/memset_64.S'
> > | diff -u tools/arch/x86/lib/memset_64.S arch/x86/lib/memset_64.S
> > 
> > This is due to the way the asm-annotations for symbol aliasing were
> > reworked, which should have no functional/performance impact.
> > 
> > Import the latest versions, adding the new style SYM_FUNC_ALIAS(),
> > SYM_FUNC_ALIAS_LOAD(), SYM_FUNC_ALIAS_WEAK() macros into the perf
> > <linux/linkage.h> header. The old style SYM_FUNC_START_ALIAS() and
> > SYM_FUNC_END_ALIAS() macros are removed.
> > 
> > Other than removing the build-time warning, there should be no
> > functional change as a result of this patch.
> 
> These changes should probably be squashed with their corresponding
> original kernel changes to avoid breaking bisection for the warnings.
> And it helps to keep the interdependent changes together.

Sure; done for v4.

Doing that highlighted a couple of fixups I failed to make to the
tools/perf/ copy; I've fixed those up.

Thanks,
Mark.