linux-kernel - Re: [PATCH 1/4] extcon: int3496: Make the driver a bit less verbose

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 16 Feb 2022 10:27:17 +0900
From:   Chanwoo Choi <cw00.choi@...sung.com>
To:     Hans de Goede <hdegoede@...hat.com>,
        MyungJoo Ham <myungjoo.ham@...sung.com>
Cc:     Stephan Gerhold <stephan@...hold.net>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] extcon: int3496: Make the driver a bit less verbose

On 12/29/21 2:01 AM, Hans de Goede wrote:
> On all devices which I have with an INT3496 ACPI device,
> there is only an ID pin defined.
> 
> Change the log-messages about not being able to get GPIOs for
> "VBUS EN" and "USB MUX" to use dev_dbg().
> 
> Signed-off-by: Hans de Goede <hdegoede@...hat.com>
> ---
>  drivers/extcon/extcon-intel-int3496.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/extcon/extcon-intel-int3496.c b/drivers/extcon/extcon-intel-int3496.c
> index fb527c23639e..df6ab4ef46f5 100644
> --- a/drivers/extcon/extcon-intel-int3496.c
> +++ b/drivers/extcon/extcon-intel-int3496.c
> @@ -121,11 +121,11 @@ static int int3496_probe(struct platform_device *pdev)
>  
>  	data->gpio_vbus_en = devm_gpiod_get(dev, "vbus", GPIOD_ASIS);
>  	if (IS_ERR(data->gpio_vbus_en))
> -		dev_info(dev, "can't request VBUS EN GPIO\n");
> +		dev_dbg(dev, "can't request VBUS EN GPIO\n");
>  
>  	data->gpio_usb_mux = devm_gpiod_get(dev, "mux", GPIOD_ASIS);
>  	if (IS_ERR(data->gpio_usb_mux))
> -		dev_info(dev, "can't request USB MUX GPIO\n");
> +		dev_dbg(dev, "can't request USB MUX GPIO\n");
>  
>  	/* register extcon device */
>  	data->edev = devm_extcon_dev_allocate(dev, int3496_cable);
> 

Applied them (patch1-4). Thanks.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics