linux-kernel - Re: [PATCH -V12 1/3] NUMA Balancing: add page promotion counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87sfsj9or8.fsf@yhuang6-desk2.ccr.corp.intel.com>
Date:   Wed, 16 Feb 2022 16:52:59 +0800
From:   "Huang, Ying" <ying.huang@...el.com>
To:     Oscar Salvador <osalvador@...e.de>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Mel Gorman <mgorman@...hsingularity.net>,
        Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, Feng Tang <feng.tang@...el.com>,
        Yang Shi <shy828301@...il.com>,
        Baolin Wang <baolin.wang@...ux.alibaba.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Michal Hocko <mhocko@...e.com>,
        Rik van Riel <riel@...riel.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Zi Yan <ziy@...dia.com>, Wei Xu <weixugc@...gle.com>,
        Shakeel Butt <shakeelb@...gle.com>,
        zhongjiang-ali <zhongjiang-ali@...ux.alibaba.com>
Subject: Re: [PATCH -V12 1/3] NUMA Balancing: add page promotion counter

Oscar Salvador <osalvador@...e.de> writes:

> On Wed, Feb 16, 2022 at 03:38:13PM +0800, Huang Ying wrote:
>> In a system with multiple memory types, e.g. DRAM and PMEM, the CPU
>> and DRAM in one socket will be put in one NUMA node as before, while
>> the PMEM will be put in another NUMA node as described in the
>> description of the commit c221c0b0308f ("device-dax: "Hotplug"
>> persistent memory for use like normal RAM").  So, the NUMA balancing
>> mechanism will identify all PMEM accesses as remote access and try to
>> promote the PMEM pages to DRAM.
>> 
>> To distinguish the number of the inter-type promoted pages from that
>> of the inter-socket migrated pages.  A new vmstat count is added.  The
>> counter is per-node (count in the target node).  So this can be used
>> to identify promotion imbalance among the NUMA nodes.
>> 
>> Signed-off-by: "Huang, Ying" <ying.huang@...el.com>
>> Reviewed-by: Yang Shi <shy828301@...il.com>
>> Tested-by: Baolin Wang <baolin.wang@...ux.alibaba.com>
>> Reviewed-by: Baolin Wang <baolin.wang@...ux.alibaba.com>
>> Acked-by: Johannes Weiner <hannes@...xchg.org>
>> Cc: Andrew Morton <akpm@...ux-foundation.org>
>> Cc: Michal Hocko <mhocko@...e.com>
>> Cc: Rik van Riel <riel@...riel.com>
>> Cc: Mel Gorman <mgorman@...hsingularity.net>
>> Cc: Peter Zijlstra <peterz@...radead.org>
>> Cc: Dave Hansen <dave.hansen@...ux.intel.com>
>> Cc: Zi Yan <ziy@...dia.com>
>> Cc: Wei Xu <weixugc@...gle.com>
>> Cc: osalvador <osalvador@...e.de>
>> Cc: Shakeel Butt <shakeelb@...gle.com>
>> Cc: zhongjiang-ali <zhongjiang-ali@...ux.alibaba.com>
>> Cc: linux-kernel@...r.kernel.org
>> Cc: linux-mm@...ck.org
>> ---
> ...
>
>> @@ -2072,6 +2072,7 @@ int migrate_misplaced_page(struct page *page, struct vm_area_struct *vma,
>>  	pg_data_t *pgdat = NODE_DATA(node);
>>  	int isolated;
>>  	int nr_remaining;
>> +	int nr_succeeded;
>
> I think we should make this consistent and make it "unsigned int".
> That is what migrate_pages() expects, and what the other caller using
> nr_succeeded (demote_page_list()) already uses.
> Unless there is a strong reason not to do so.

Yes.  Will do that in the next version.

> Reviewed-by: Oscar Salvador <osalvador@...e.de>

Thanks!

Best Regards,
Huang, Ying