lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 16 Feb 2022 12:50:41 +0300 From: Pavel Skripkin <paskripkin@...il.com> To: Phillip Potter <phil@...lpotter.co.uk>, gregkh@...uxfoundation.org Cc: dan.carpenter@...cle.com, Larry.Finger@...inger.net, straube.linux@...il.com, martin@...ser.cx, linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2 03/15] staging: r8188eu: remove converted DBG_88E calls from core/rtw_mlme_ext.c Hi Phillip, On 2/16/22 04:06, Phillip Potter wrote: > Remove all the netdev_dbg/pr_debug calls that were previously converted > from DBG_88E inside core/rtw_mlme_ext.c. Due to the sheer number of > lines, this patch is separated out for ease of review. After some thought, > it makes more sense to just entirely strip all of these calls, so that > debugging code in the driver can be more consistent and useful going > forwards. > > Signed-off-by: Phillip Potter <phil@...lpotter.co.uk> [code snip] > if (pstat->aid > 0) { > - netdev_dbg(padapter->pnetdev, "old AID %d\n", pstat->aid); > } else { Ok, this one has same issues as 2nd one. I am going to stop reviewing this series for now, because looks like I am missing some context... With regards, Pavel Skripkin
Powered by blists - more mailing lists