[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220217211134.GA305475@bhelgaas>
Date: Thu, 17 Feb 2022 15:11:34 -0600
From: Bjorn Helgaas <helgaas@...nel.org>
To: Pali Rohár <pali@...nel.org>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
Rob Herring <robh@...nel.org>,
Krzysztof Wilczyński <kw@...ux.com>,
Ray Jui <rjui@...adcom.com>,
Scott Branden <sbranden@...adcom.com>,
bcm-kernel-feedback-list@...adcom.com, linux-pci@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH v2 1/2] PCI: Add defines for normal and
subtractive PCI bridges
On Mon, Feb 14, 2022 at 12:41:08PM +0100, Pali Rohár wrote:
> Add following two new PCI class codes defines into pci_ids.h include file:
>
> PCI_CLASS_BRIDGE_PCI_NORMAL
> PCI_CLASS_BRIDGE_PCI_SUBTRACTIVE
>
> And use these defines in all kernel code for describing PCI class codes for
> normal and subtractive PCI bridges.
Looks good; is this another case?
drivers/pci/controller/pci-mvebu.c: dev_rev |= (PCI_CLASS_BRIDGE_PCI << 8) << 8;
> static void quirk_sb1250_ht(struct pci_dev *dev)
> {
> - dev->class = PCI_CLASS_BRIDGE_PCI << 8;
> + dev->class = PCI_CLASS_BRIDGE_PCI_NORMAL;
Powered by blists - more mailing lists