linux-kernel - Re: [RESEND PATCH v2 1/2] PCI: Add defines for normal and subtractive PCI bridges

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220217212145.fvwc2axp6nyeqs36@pali>
Date:   Thu, 17 Feb 2022 22:21:45 +0100
From:   Pali Rohár <pali@...nel.org>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH v2 1/2] PCI: Add defines for normal and
 subtractive PCI bridges

On Thursday 17 February 2022 15:11:34 Bjorn Helgaas wrote:
> On Mon, Feb 14, 2022 at 12:41:08PM +0100, Pali Rohár wrote:
> > Add following two new PCI class codes defines into pci_ids.h include file:
> > 
> >   PCI_CLASS_BRIDGE_PCI_NORMAL
> >   PCI_CLASS_BRIDGE_PCI_SUBTRACTIVE
> > 
> > And use these defines in all kernel code for describing PCI class codes for
> > normal and subtractive PCI bridges.
> 
> Looks good; is this another case?
> 
>   drivers/pci/controller/pci-mvebu.c:     dev_rev |= (PCI_CLASS_BRIDGE_PCI << 8) << 8;

Yes! It is.

> >  static void quirk_sb1250_ht(struct pci_dev *dev)
> >  {
> > -	dev->class = PCI_CLASS_BRIDGE_PCI << 8;
> > +	dev->class = PCI_CLASS_BRIDGE_PCI_NORMAL;