linux-kernel - RE: [PATCH] power: supply: da9150-fg: Use devm_delayed_work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB9PR10MB465210AEF84FD0F390B1616480379@DB9PR10MB4652.EURPRD10.PROD.OUTLOOK.COM>
Date:   Fri, 18 Feb 2022 13:13:10 +0000
From:   Adam Thomson <Adam.Thomson.Opensource@...semi.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Support Opensource <Support.Opensource@...semi.com>,
        Sebastian Reichel <sre@...nel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>
Subject: RE: [PATCH] power: supply: da9150-fg: Use
 devm_delayed_work_autocancel()

On 13 February 2022 17:55, Christophe JAILLET wrote:

> This driver only uses managed resources, except for the delayed work, if
> it is used.
> 
> Use devm_delayed_work_autocancel() to also manage the delayed work.
> The error handling path of the probe and the remove function can both be
> removed.
> 
> This saves a few lines of code.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@...semi.com>