linux-kernel - Re: [PATCH] power: supply: da9150-fg: Use devm_delayed_work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220224112146.ytrcop3lcjfd6f6n@mercury.elektranox.org>
Date:   Thu, 24 Feb 2022 12:21:46 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Adam Thomson <Adam.Thomson.Opensource@...semi.com>
Cc:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Support Opensource <Support.Opensource@...semi.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>
Subject: Re: [PATCH] power: supply: da9150-fg: Use
 devm_delayed_work_autocancel()

Hi,

On Fri, Feb 18, 2022 at 01:13:10PM +0000, Adam Thomson wrote:
> On 13 February 2022 17:55, Christophe JAILLET wrote:
> 
> > This driver only uses managed resources, except for the delayed work, if
> > it is used.
> > 
> > Use devm_delayed_work_autocancel() to also manage the delayed work.
> > The error handling path of the probe and the remove function can both be
> > removed.
> > 
> > This saves a few lines of code.
> > 
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> 
> Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@...semi.com>

Thanks, queued.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)