linux-kernel - Re: [PATCH] power: supply: sbs-charger: Don't cancel work that is not initialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220224112312.cjbz4vt3spe2go4b@mercury.elektranox.org>
Date:   Thu, 24 Feb 2022 12:23:12 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Nicolas Saenz Julienne <nicolas.saenz@...dys.net>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH] power: supply: sbs-charger: Don't cancel work that is
 not initialized

Hi,

On Sun, Feb 13, 2022 at 06:07:03PM +0100, Christophe JAILLET wrote:
> This driver can use an interrupt or polling in order get the charger's
> status.
> 
> When using polling, a delayed work is used.
> 
> However, the remove() function unconditionally call
> cancel_delayed_work_sync(), even if the delayed work is not used and is not
> initialized.
> 
> In order to fix it, use devm_delayed_work_autocancel() and remove the now
> useless remove() function.
> 
> Fixes: feb583e37f8a ("power: supply: add sbs-charger driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---

Thanks, queued.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)