linux-kernel - Re: [tip:sched/core 27/28] kernel/sched/topology.c:2284:39: sparse: sparse: incorrect type in assignment (different address spaces)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c1cce9f7-6501-b561-325d-126fa075e520@amd.com>
Date:   Fri, 18 Feb 2022 22:14:00 +0530
From:   K Prateek Nayak <kprateek.nayak@....com>
To:     Mel Gorman <mgorman@...e.de>
Cc:     kbuild-all@...ts.01.org, kernel test robot <lkp@...el.com>,
        linux-kernel@...r.kernel.org, x86@...nel.org,
        Peter Zijlstra <peterz@...radead.org>,
        "Gautham R. Shenoy" <gautham.shenoy@....com>
Subject: Re: [tip:sched/core 27/28] kernel/sched/topology.c:2284:39: sparse:
 sparse: incorrect type in assignment (different address spaces)

Hello Mel,

On 2/17/2022 6:28 AM, kernel test robot wrote:
> [..snip..]
>   2282					/* Set span based on the first NUMA domain. */
>   2283					top = sd;
>> 2284					top_p = top->parent;
>   2285					while (top_p && !(top_p->flags & SD_NUMA)) {
>> 2286						top = top->parent;
>   2287						top_p = top->parent;
>   2288					}
>   2289					imb_span = top_p ? top_p->span_weight : sd->span_weight;

I was looking into this sparse warning when I noticed
that the variable "top" is actually redundant - "sd"
and "top_p" can suffice for the computation "top" is
involved in. I've created a patch to fix this warning
and remove the redundant variable top while at it.
https://lore.kernel.org/lkml/20220218162743.1134-1-kprateek.nayak@amd.com/
--
Thanks and Regards,
Prateek