linux-kernel - Re: [PATCH] bpf: Initialize ret to 0 inside btf_populate_kfunc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQLTcYJSNHGCKNso4K6V+SGT93c6YCmEUNrkJooix3sLHQ@mail.gmail.com>
Date:   Sat, 19 Feb 2022 17:39:31 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Kumar Kartikeya Dwivedi <memxor@...il.com>
Cc:     Souptick Joarder <jrdr.linux@...il.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Network Development <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] bpf: Initialize ret to 0 inside btf_populate_kfunc_set()

On Sat, Feb 19, 2022 at 4:42 PM Kumar Kartikeya Dwivedi
<memxor@...il.com> wrote:
>
> On Sat, Feb 19, 2022 at 10:09:15PM IST, Souptick Joarder wrote:
> > From: "Souptick Joarder (HPE)" <jrdr.linux@...il.com>
> >
> > Kernel test robot reported below error ->
> >
> > kernel/bpf/btf.c:6718 btf_populate_kfunc_set()
> > error: uninitialized symbol 'ret'.
> >
> > Initialize ret to 0.
> >
> > Fixes:        dee872e124e8 ("bpf: Populate kfunc BTF ID sets in struct btf")
> > Reported-by: kernel test robot <lkp@...el.com>
> > Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@...il.com>
> > ---
>
> Thanks for the fix.
>
> Acked-by: Kumar Kartikeya Dwivedi <memxor@...il.com>

Applied to bpf-next, since the bug will not trigger in practice.