linux-kernel - Re: [PATCH] Correct documentation comments for x86 csum_and_copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 20 Feb 2022 15:24:48 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     William Kucharski <william.kucharski@...cle.com>
Cc:     linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        "H . Peter Anvin" <hpa@...or.com>,
        Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH] Correct documentation comments for x86
 csum_and_copy_...user()

On Sat, Feb 05, 2022 at 05:14:56AM -0700, William Kucharski wrote:
> Clean up of calling conventions for csum_and_copy_..._user() did not update
> associated documentation comments to account for the removal of additional
> parameters.
> 
> Fixes: c693cc4676a0 ("saner calling conventions for csum_and_copy_..._user()")
> Signed-off-by: William Kucharski <william.kucharski@...cle.com>
> ---
>  arch/x86/lib/csum-wrappers_64.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/arch/x86/lib/csum-wrappers_64.c b/arch/x86/lib/csum-wrappers_64.c
> index 189344924a2b..25d533502693 100644
> --- a/arch/x86/lib/csum-wrappers_64.c
> +++ b/arch/x86/lib/csum-wrappers_64.c
> @@ -14,8 +14,6 @@
>   * @src: source address (user space)
>   * @dst: destination address
>   * @len: number of bytes to be copied.
> - * @isum: initial sum that is added into the result (32bit unfolded)
> - * @errp: set to -EFAULT for an bad source address.
>   *
>   * Returns an 32bit unfolded checksum of the buffer.
>   * src and dst are best aligned to 64bits.
> @@ -39,8 +37,6 @@ EXPORT_SYMBOL(csum_and_copy_from_user);
>   * @src: source address
>   * @dst: destination address (user space)
>   * @len: number of bytes to be copied.
> - * @isum: initial sum that is added into the result (32bit unfolded)
> - * @errp: set to -EFAULT for an bad destination address.
>   *
>   * Returns an 32bit unfolded checksum of the buffer.
>   * src and dst are best aligned to 64bits.
> @@ -64,7 +60,6 @@ EXPORT_SYMBOL(csum_and_copy_to_user);
>   * @src: source address
>   * @dst: destination address
>   * @len: number of bytes to be copied.
> - * @sum: initial sum that is added into the result (32bit unfolded)
>   *
>   * Returns an 32bit unfolded checksum of the buffer.
>   */
> -- 

Wanna fix the rest of kernel-doc formatting issues while at it?

$ ./scripts/kernel-doc -v -none arch/x86/lib/csum-wrappers_64.c
arch/x86/lib/csum-wrappers_64.c:13: info: Scanning doc for function csum_and_copy_from_user
arch/x86/lib/csum-wrappers_64.c:23: warning: No description found for return value of 'csum_and_copy_from_user'
arch/x86/lib/csum-wrappers_64.c:36: info: Scanning doc for function csum_and_copy_to_user
arch/x86/lib/csum-wrappers_64.c:46: warning: No description found for return value of 'csum_and_copy_to_user'
arch/x86/lib/csum-wrappers_64.c:59: info: Scanning doc for function csum_partial_copy_nocheck
arch/x86/lib/csum-wrappers_64.c:68: warning: No description found for return value of 'csum_partial_copy_nocheck'

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette