[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20220220143348.44f71d62@jic23-huawei>
Date: Sun, 20 Feb 2022 14:33:48 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Jagath Jog J <jagathjog1996@...il.com>
Cc: lars@...afoo.de, andy.shevchenko@...il.com, sst@...zta.fm,
robh+dt@...nel.org, linux-iio@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 0/7] iio: potentiometer: Add support for DS3502
On Sun, 20 Feb 2022 08:16:25 +0530
Jagath Jog J <jagathjog1996@...il.com> wrote:
> Add dt-bindings and support for Maxim DS3502 into existing ds1803 driver.
> DS3502 is a 7 bit Nonvolatile Digital Potentiometer.
Looks good to me. Will leave it on list a few more days though
to allow others to comment if they wish.
Nice work,
Thanks,
Jonathan
>
> Changes since v3:
> 1. Dropped the chip type switch statement in read_raw function.
> 2. Added device specific read function pointer in their structure.
> 3. Added two separate functions to read values from two different types
> of devices.
>
> Changes since v2:
> 1. Addressed Andy Shevchenko comments.
> 2. Adding device name in Kconfig file.
> 3. Spliting up of patch into 3 patches.
> 4. Adding channel info into ds1803_cfg in separate patch.
> 5. Dropping the use of enum in firmware data instead using previous
> pointer method for accessing device specific data.
> 6. Separate patch for using firmware provided data instead of
> id->driver_data.
> 7. Adding DS3502 support in separate patch.
>
> Changes since v1:
> 1. Fixes the alignment to match the open parenthesis in separate patch.
> 2. Adding available functionality for ds1803 driver in separate patch.
> 3. Moving maxim_potentiometer members into ds1803_cfg structure.
> 4. Droping of the INFO_ENABLE channel type.
> 5. Firmware entry with data is used instead of id->driver_data to
> to retrieve the chip specific data.
>
> Jagath Jog J (7):
> iio: potentiometer: Alignment to match the open parenthesis
> iio: potentiometer: Add available functionality
> iio: potentiometer: Add channel information in device data
> iio: potentiometer: Change to firmware provided data
> iio: potentiometer: Add device specific read_raw function
> iio: potentiometer: Add support for Maxim DS3502
> dt-bindings: iio: potentiometer: Add Maxim DS3502 in trivial-devices
>
> .../devicetree/bindings/trivial-devices.yaml | 2 +
> drivers/iio/potentiometer/Kconfig | 6 +-
> drivers/iio/potentiometer/ds1803.c | 153 +++++++++++++-----
> 3 files changed, 121 insertions(+), 40 deletions(-)
>
Powered by blists - more mailing lists