linux-kernel - Re: [PATCH AUTOSEL 4.19 06/11] kconfig: let 'shell' return enough output for deep path names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220220100123.GB7321@amd>
Date:   Sun, 20 Feb 2022 11:01:23 +0100
From:   Pavel Machek <pavel@...x.de>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Brenda Streiff <brenda.streiff@...com>,
        Masahiro Yamada <masahiroy@...nel.org>,
        linux-kbuild@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 4.19 06/11] kconfig: let 'shell' return enough
 output for deep path names

Hi!

> [ Upstream commit 8a4c5b2a6d8ea079fa36034e8167de87ab6f8880 ]
> 
> The 'shell' built-in only returns the first 256 bytes of the command's
> output. In some cases, 'shell' is used to return a path; by bumping up
> the buffer size to 4096 this lets us capture up to PATH_MAX.

If the idea is to support up-to PATH_MAX, perhaps open-coded 4096
should be replaced by PATH_MAX in the code, too?

Best regards,
								Pavel

> +++ b/scripts/kconfig/preprocess.c
> @@ -138,7 +138,7 @@ static char *do_lineno(int argc, char *argv[])
>  static char *do_shell(int argc, char *argv[])
>  {
>  	FILE *p;
> -	char buf[256];
> +	char buf[4096];
>  	char *cmd;
>  	size_t nread;
>  	int i;

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)