linux-kernel - Re: [PATCH v9 02/10] dt-bindings: arm: sunplus: Add bindings for Sunplus SP7021 SoC boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <141c1b3e-b116-a0eb-78ad-dd9263880e9d@kernel.org>
Date:   Mon, 21 Feb 2022 17:29:32 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Qin Jian <qinjian@...lus1.com>, robh+dt@...nel.org
Cc:     mturquette@...libre.com, sboyd@...nel.org, tglx@...utronix.de,
        maz@...nel.org, p.zabel@...gutronix.de, linux@...linux.org.uk,
        broonie@...nel.org, arnd@...db.de, stefan.wahren@...e.com,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
        wells.lu@...plus.com, Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v9 02/10] dt-bindings: arm: sunplus: Add bindings for
 Sunplus SP7021 SoC boards

On 21/02/2022 04:29, Qin Jian wrote:
> This introduces bindings for boards based Sunplus SP7021 SoC.
> 
> Reviewed-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Qin Jian <qinjian@...lus1.com>
> ---
>  .../bindings/arm/sunplus,sp7021.yaml          | 27 +++++++++++++++++++
>  MAINTAINERS                                   |  7 +++++
>  2 files changed, 34 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/sunplus,sp7021.yaml
> 
> diff --git a/Documentation/devicetree/bindings/arm/sunplus,sp7021.yaml b/Documentation/devicetree/bindings/arm/sunplus,sp7021.yaml
> new file mode 100644
> index 000000000..5b9985b73
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/sunplus,sp7021.yaml
> @@ -0,0 +1,27 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) Sunplus Co., Ltd. 2021
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/sunplus,sp7021.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sunplus SP7021 Boards Device Tree Bindings
> +
> +maintainers:
> +  - qinjian <qinjian@...lus1.com>
> +
> +description: |
> +  ARM platforms using Sunplus SP7021, an ARM Cortex A7 (4-cores) based SoC.
> +  Wiki: https://sunplus-tibbo.atlassian.net/wiki/spaces/doc/overview
> +
> +properties:
> +  $nodename:
> +    const: '/'
> +  compatible:
> +    oneOf:
> +      - items:
> +          - const: sunplus,sp7021-achip
> +

You did not publish DTS so bigger picture and context are missing here.
Is it a SoC compatible? A board compatible? Why only one? Against what
does it validate?

This binding looks incomplete.


Best regards,
Krzysztof