linux-kernel - Re: [PATCH] memory: tegra: Add APE memory clients for Tegra234

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202202212350.xbGhqWuI-lkp@intel.com>
Date:   Mon, 21 Feb 2022 23:41:24 +0800
From:   kernel test robot <lkp@...el.com>
To:     Sameer Pujar <spujar@...dia.com>,
        krzysztof.kozlowski@...onical.com, thierry.reding@...il.com
Cc:     kbuild-all@...ts.01.org, jonathanh@...dia.com,
        linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org,
        Sameer Pujar <spujar@...dia.com>
Subject: Re: [PATCH] memory: tegra: Add APE memory clients for Tegra234

Hi Sameer,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tegra/for-next]
[also build test ERROR on next-20220217]
[cannot apply to v5.17-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Sameer-Pujar/memory-tegra-Add-APE-memory-clients-for-Tegra234/20220220-190451
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git for-next
config: arm64-randconfig-c004-20220220 (https://download.01.org/0day-ci/archive/20220221/202202212350.xbGhqWuI-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/2432353686ce99492ca9a6100ba6b121fa858950
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Sameer-Pujar/memory-tegra-Add-APE-memory-clients-for-Tegra234/20220220-190451
        git checkout 2432353686ce99492ca9a6100ba6b121fa858950
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/memory/tegra/tegra234.c:74:23: error: 'TEGRA234_MEMORY_CLIENT_APEDMAR' undeclared here (not in a function); did you mean 'TEGRA234_MEMORY_CLIENT_BPMPDMAR'?
      74 |                 .id = TEGRA234_MEMORY_CLIENT_APEDMAR,
         |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |                       TEGRA234_MEMORY_CLIENT_BPMPDMAR
>> drivers/memory/tegra/tegra234.c:76:24: error: 'TEGRA234_SID_APE' undeclared here (not in a function); did you mean 'TEGRA234_SID_BPMP'?
      76 |                 .sid = TEGRA234_SID_APE,
         |                        ^~~~~~~~~~~~~~~~
         |                        TEGRA234_SID_BPMP
>> drivers/memory/tegra/tegra234.c:84:23: error: 'TEGRA234_MEMORY_CLIENT_APEDMAW' undeclared here (not in a function); did you mean 'TEGRA234_MEMORY_CLIENT_BPMPDMAW'?
      84 |                 .id = TEGRA234_MEMORY_CLIENT_APEDMAW,
         |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |                       TEGRA234_MEMORY_CLIENT_BPMPDMAW


vim +74 drivers/memory/tegra/tegra234.c

    11	
    12	static const struct tegra_mc_client tegra234_mc_clients[] = {
    13		{
    14			.id = TEGRA234_MEMORY_CLIENT_SDMMCRAB,
    15			.name = "sdmmcrab",
    16			.sid = TEGRA234_SID_SDMMC4,
    17			.regs = {
    18				.sid = {
    19					.override = 0x318,
    20					.security = 0x31c,
    21				},
    22			},
    23		}, {
    24			.id = TEGRA234_MEMORY_CLIENT_SDMMCWAB,
    25			.name = "sdmmcwab",
    26			.sid = TEGRA234_SID_SDMMC4,
    27			.regs = {
    28				.sid = {
    29					.override = 0x338,
    30					.security = 0x33c,
    31				},
    32			},
    33		}, {
    34			.id = TEGRA234_MEMORY_CLIENT_BPMPR,
    35			.name = "bpmpr",
    36			.sid = TEGRA234_SID_BPMP,
    37			.regs = {
    38				.sid = {
    39					.override = 0x498,
    40					.security = 0x49c,
    41				},
    42			},
    43		}, {
    44			.id = TEGRA234_MEMORY_CLIENT_BPMPW,
    45			.name = "bpmpw",
    46			.sid = TEGRA234_SID_BPMP,
    47			.regs = {
    48				.sid = {
    49					.override = 0x4a0,
    50					.security = 0x4a4,
    51				},
    52			},
    53		}, {
    54			.id = TEGRA234_MEMORY_CLIENT_BPMPDMAR,
    55			.name = "bpmpdmar",
    56			.sid = TEGRA234_SID_BPMP,
    57			.regs = {
    58				.sid = {
    59					.override = 0x4a8,
    60					.security = 0x4ac,
    61				},
    62			},
    63		}, {
    64			.id = TEGRA234_MEMORY_CLIENT_BPMPDMAW,
    65			.name = "bpmpdmaw",
    66			.sid = TEGRA234_SID_BPMP,
    67			.regs = {
    68				.sid = {
    69					.override = 0x4b0,
    70					.security = 0x4b4,
    71				},
    72			},
    73		}, {
  > 74			.id = TEGRA234_MEMORY_CLIENT_APEDMAR,
    75			.name = "apedmar",
  > 76			.sid = TEGRA234_SID_APE,
    77			.regs = {
    78				.sid = {
    79					.override = 0x4f8,
    80					.security = 0x4fc,
    81				},
    82			},
    83		}, {
  > 84			.id = TEGRA234_MEMORY_CLIENT_APEDMAW,
    85			.name = "apedmaw",
    86			.sid = TEGRA234_SID_APE,
    87			.regs = {
    88				.sid = {
    89					.override = 0x500,
    90					.security = 0x504,
    91				},
    92			},
    93		},
    94	};
    95	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org