linux-kernel - Re: [PATCH v2 04/10] random: group initialization wait functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Feb 2022 16:10:56 +0100
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Eric Biggers <ebiggers@...nel.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Dominik Brodowski <linux@...inikbrodowski.net>,
        "Theodore Ts'o" <tytso@....edu>
Subject: Re: [PATCH v2 04/10] random: group initialization wait functions

On Mon, Feb 21, 2022 at 5:49 AM Eric Biggers <ebiggers@...nel.org> wrote:
>
> On Sat, Feb 12, 2022 at 01:23:12PM +0100, Jason A. Donenfeld wrote:
> > +/*
> > + * Static global variables
> > + */
> > +static DECLARE_WAIT_QUEUE_HEAD(random_write_wait);
> > +static struct fasync_struct *fasync;
> > +
> > +static int crng_init_cnt = 0;
> > +static void _get_random_bytes(void *buf, size_t nbytes);
>
> A couple oddities here:
>
>   - 'fasync' is being defined twice.  It's already defined earlier in the file.
>   - The prototype for _get_random_bytes() is unnecessary.
>
> Other than that this patch looks good.

Nice catch, thanks. Will fix.

Jason