linux-kernel - Re: [PATCH v2 07/10] random: group entropy collection functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHmME9qs5gBFrGXGktB9kOx8oSdfow+-Tc=ie7b1J8aT5SfQ7Q@mail.gmail.com>
Date:   Mon, 21 Feb 2022 16:17:26 +0100
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Eric Biggers <ebiggers@...nel.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Dominik Brodowski <linux@...inikbrodowski.net>,
        "Theodore Ts'o" <tytso@....edu>
Subject: Re: [PATCH v2 07/10] random: group entropy collection functions

On Mon, Feb 21, 2022 at 6:13 AM Eric Biggers <ebiggers@...nel.org> wrote:
>
> On Sat, Feb 12, 2022 at 01:23:15PM +0100, Jason A. Donenfeld wrote:
> > +/**********************************************************************
> > + *
> > + * Entropy collection routines.
> > + *
> > + * The following exported functions are used for pushing entropy into
> > + * the above entropy accumulation routines:
> > + *
> > + *   void add_device_randomness(const void *buf, size_t size);
> > + *   void add_input_randomness(unsigned int type, unsigned int code,
> > + *                             unsigned int value);
> > + *   void add_interrupt_randomness(int irq);
> > + *   void add_disk_randomness(struct gendisk *disk);
> > + *   void add_hwgenerator_randomness(const void *buffer, size_t count,
> > + *                                   size_t entropy);
> > + *   void add_bootloader_randomness(const void *buf, size_t size);
> > + *
> > + * add_device_randomness() adds data to the input pool that
> > + * is likely to differ between two devices (or possibly even per boot).
> > + * This would be things like MAC addresses or serial numbers, or the
> > + * read-out of the RTC. This does *not* credit any actual entropy to
> > + * the pool, but it initializes the pool to different values for devices
> > + * that might otherwise be identical and have very little entropy
> > + * available to them (particularly common in the embedded world).
>
> Perhaps this comment should match the order in which these functions are defined
> in the file?

Sure. Will do