linux-kernel - Re: [PATCH v4 2/3] dt-bindings:iio:amplifiers: add ada4250 doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <61e964b4-a406-7721-f3d4-26754c7f865c@kernel.org>
Date:   Mon, 21 Feb 2022 17:35:42 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Antoniu Miclaus <antoniu.miclaus@...log.com>, jic23@...nel.org,
        robh+dt@...nel.org, linux-iio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/3] dt-bindings:iio:amplifiers: add ada4250 doc

On 21/02/2022 10:27, Antoniu Miclaus wrote:
> Add device tree bindings for the ADA4250 driver.
> 
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@...log.com>
> ---
> changes in v4:
>  - add `spi-max-frequency` property
>  - use generic node naming
>  .../bindings/iio/amplifiers/adi,ada4250.yaml  | 50 +++++++++++++++++++
>  1 file changed, 50 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml
> 

Please do not resend without fixing pointed out issues. It just looks
you ignore comments.

Please fix or respond to previous comments. Please also fix all common
issues recently pointed out for all Analog devices - folks from Analog
are making the same mistakes. Reviewing the same mistake is a bit a
waste of time. Much more appreciated is when team applies one feedback
to all its submissions. IOW, do not repeat the same mistake second time.

Best regards,
Krzysztof