linux-kernel - RE: [PATCH v4 2/3] dt-bindings:iio:amplifiers: add ada4250 doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY4PR03MB3399F6E389A3014678849ADC9B3B9@CY4PR03MB3399.namprd03.prod.outlook.com>
Date:   Tue, 22 Feb 2022 09:21:28 +0000
From:   "Miclaus, Antoniu" <Antoniu.Miclaus@...log.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        "jic23@...nel.org" <jic23@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v4 2/3] dt-bindings:iio:amplifiers: add ada4250 doc


--
Antoniu Miclăuş

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: Monday, February 21, 2022 6:36 PM
> To: Miclaus, Antoniu <Antoniu.Miclaus@...log.com>; jic23@...nel.org;
> robh+dt@...nel.org; linux-iio@...r.kernel.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v4 2/3] dt-bindings:iio:amplifiers: add ada4250 doc
> 
> [External]
> 
> On 21/02/2022 10:27, Antoniu Miclaus wrote:
> > Add device tree bindings for the ADA4250 driver.
> >
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@...log.com>
> > ---
> > changes in v4:
> >  - add `spi-max-frequency` property
> >  - use generic node naming
> >  .../bindings/iio/amplifiers/adi,ada4250.yaml  | 50 +++++++++++++++++++
> >  1 file changed, 50 insertions(+)
> >  create mode 100644
> Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml
> >
> 
> Please do not resend without fixing pointed out issues. It just looks
> you ignore comments.
> 
> Please fix or respond to previous comments. Please also fix all common
> issues recently pointed out for all Analog devices - folks from Analog
> are making the same mistakes. Reviewing the same mistake is a bit a
> waste of time. Much more appreciated is when team applies one feedback
> to all its submissions. IOW, do not repeat the same mistake second time.
> 
> 
> Best regards,
> Krzysztof

I had a look over the previous comments and I saw that some of them were 
replied by Jonathan already, therefore I fixed only those that were still valid.
Indeed I missed the "Please put the bindings patch as first in the series",
my bad on that. Let me know if I missed anything else.

Regards,
Antoniu