linux-kernel - Re: [PATCH v4 2/3] dt-bindings:iio:amplifiers: add ada4250 doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53a17fe5-4301-676a-03de-f19055a8a904@kernel.org>
Date:   Tue, 22 Feb 2022 10:28:51 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     "Miclaus, Antoniu" <Antoniu.Miclaus@...log.com>,
        "jic23@...nel.org" <jic23@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 2/3] dt-bindings:iio:amplifiers: add ada4250 doc

On 22/02/2022 10:21, Miclaus, Antoniu wrote:
>>
>> Please do not resend without fixing pointed out issues. It just looks
>> you ignore comments.
>>
>> Please fix or respond to previous comments. Please also fix all common
>> issues recently pointed out for all Analog devices - folks from Analog
>> are making the same mistakes. Reviewing the same mistake is a bit a
>> waste of time. Much more appreciated is when team applies one feedback
>> to all its submissions. IOW, do not repeat the same mistake second time.
>>
>>
>> Best regards,
>> Krzysztof
> 
> I had a look over the previous comments and I saw that some of them were 
> replied by Jonathan already, therefore I fixed only those that were still valid.
> Indeed I missed the "Please put the bindings patch as first in the series",
> my bad on that. Let me know if I missed anything else.

In this patchset you also missed spaces in the subject (after every ':'
character).

Best regards,
Krzysztof