linux-kernel - Re: [PATCH v6 05/13] module: Move latched RB-tree support to a separate file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <97c7654d-bb44-8539-1646-1cfdaddeee7e@csgroup.eu>
Date:   Mon, 21 Feb 2022 10:57:29 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Aaron Tomlin <atomlin@...hat.com>,
        "mcgrof@...nel.org" <mcgrof@...nel.org>
CC:     "cl@...ux.com" <cl@...ux.com>,
        "pmladek@...e.com" <pmladek@...e.com>,
        "mbenes@...e.cz" <mbenes@...e.cz>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "jeyu@...nel.org" <jeyu@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-modules@...r.kernel.org" <linux-modules@...r.kernel.org>,
        "live-patching@...r.kernel.org" <live-patching@...r.kernel.org>,
        "atomlin@...mlin.com" <atomlin@...mlin.com>,
        "ghalat@...hat.com" <ghalat@...hat.com>,
        "allen.lkml@...il.com" <allen.lkml@...il.com>,
        "joe@...ches.com" <joe@...ches.com>,
        "msuchanek@...e.de" <msuchanek@...e.de>,
        "oleksandr@...alenko.name" <oleksandr@...alenko.name>
Subject: Re: [PATCH v6 05/13] module: Move latched RB-tree support to a
 separate file



Le 18/02/2022 à 22:25, Aaron Tomlin a écrit :
> No functional change.
> 
> This patch migrates module latched RB-tree support
> (e.g. see __module_address()) from core module code
> into kernel/module/tree_lookup.c.
> 
> Signed-off-by: Aaron Tomlin <atomlin@...hat.com>
> ---
>   kernel/module/Makefile      |   3 +
>   kernel/module/internal.h    |  33 +++++++++
>   kernel/module/main.c        | 130 ++----------------------------------
>   kernel/module/tree_lookup.c | 109 ++++++++++++++++++++++++++++++
>   4 files changed, 149 insertions(+), 126 deletions(-)
>   create mode 100644 kernel/module/tree_lookup.c


   CC      kernel/module/main.o
kernel/module/main.c:3723:6: warning: no previous prototype for 
'module_layout' [-Wmissing-prototypes]
  3723 | void module_layout(struct module *mod,
       |      ^~~~~~~~~~~~~
   CC      kernel/module/strict_rwx.o
In file included from kernel/module/strict_rwx.c:12:
kernel/module/internal.h:140:13: warning: 'mod_tree_remove' defined but 
not used [-Wunused-function]
   140 | static void mod_tree_remove(struct module *mod) { }
       |             ^~~~~~~~~~~~~~~
kernel/module/internal.h:139:13: warning: 'mod_tree_remove_init' defined 
but not used [-Wunused-function]
   139 | static void mod_tree_remove_init(struct module *mod) { }
       |             ^~~~~~~~~~~~~~~~~~~~
kernel/module/internal.h:138:13: warning: 'mod_tree_insert' defined but 
not used [-Wunused-function]
   138 | static void mod_tree_insert(struct module *mod) { }
       |             ^~~~~~~~~~~~~~~
   CC      kernel/module/kallsyms.o
In file included from kernel/module/kallsyms.c:12:
kernel/module/internal.h:140:13: warning: 'mod_tree_remove' defined but 
not used [-Wunused-function]
   140 | static void mod_tree_remove(struct module *mod) { }
       |             ^~~~~~~~~~~~~~~
kernel/module/internal.h:139:13: warning: 'mod_tree_remove_init' defined 
but not used [-Wunused-function]
   139 | static void mod_tree_remove_init(struct module *mod) { }
       |             ^~~~~~~~~~~~~~~~~~~~
kernel/module/internal.h:138:13: warning: 'mod_tree_insert' defined but 
not used [-Wunused-function]
   138 | static void mod_tree_insert(struct module *mod) { }
       |             ^~~~~~~~~~~~~~~
   CC      kernel/module/procfs.o
In file included from kernel/module/procfs.c:13:
kernel/module/internal.h:140:13: warning: 'mod_tree_remove' defined but 
not used [-Wunused-function]
   140 | static void mod_tree_remove(struct module *mod) { }
       |             ^~~~~~~~~~~~~~~
kernel/module/internal.h:139:13: warning: 'mod_tree_remove_init' defined 
but not used [-Wunused-function]
   139 | static void mod_tree_remove_init(struct module *mod) { }
       |             ^~~~~~~~~~~~~~~~~~~~
kernel/module/internal.h:138:13: warning: 'mod_tree_insert' defined but 
not used [-Wunused-function]
   138 | static void mod_tree_insert(struct module *mod) { }
       |             ^~~~~~~~~~~~~~~


Christophe