linux-kernel - Re: Error when compiling kernel module - Re: More power management updates for v5.17-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gb4Dra_NTQjcP8T7Cqy6ejRUV3MgcKC0RPSL_0kqTsuA@mail.gmail.com>
Date:   Mon, 21 Feb 2022 17:44:28 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Paul Cercueil <paul@...pouillou.net>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        eh kernel <ehkernel@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Error when compiling kernel module - Re: More power management
 updates for v5.17-rc1

On Mon, Feb 21, 2022 at 5:29 PM Paul Cercueil <paul@...pouillou.net> wrote:
>
> Hi Rafael,
>
> Le lun., févr. 21 2022 at 17:18:51 +0100, Rafael J. Wysocki
> <rafael@...nel.org> a écrit :
> > On Mon, Feb 21, 2022 at 1:15 PM eh kernel <ehkernel@...il.com> wrote:
> >>
> >>  Hi Rafael,
> >>
> >>  I now get an error when compiling the kernel module (out-of-tree)
> >> with the new PM macros.
> >>
> >>  /home/ubuntu/pressure/bmp280-core.c:1163:28: error: expected
> >> ‘)’ before ‘(’ token
> >>   1163 |      bmp280_runtime_resume, NULL);
> >
> > Which of the macros has triggered this error?
>
> I think the bug was introduced by 23a133c1ba67 ("iio:adc:ab8500: Switch
> from CONFIG_PM guards to pm_ptr() etc")
>
> The macro takes 4 arguments and its first parameter should be the
> dev_pm_ops name, so "ab8500_gpadc_pm_ops".
>
> It slipped during review.

I see.

Can you fix this, please?