linux-kernel - Re: Error when compiling kernel module - Re: More power management updates for v5.17-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <VSXN7R.644PDRMKJL992@crapouillou.net>
Date:   Mon, 21 Feb 2022 16:29:19 +0000
From:   Paul Cercueil <paul@...pouillou.net>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     eh kernel <ehkernel@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Error when compiling kernel module - Re: More power management
 updates for v5.17-rc1

Hi Rafael,

Le lun., févr. 21 2022 at 17:18:51 +0100, Rafael J. Wysocki 
<rafael@...nel.org> a écrit :
> On Mon, Feb 21, 2022 at 1:15 PM eh kernel <ehkernel@...il.com> wrote:
>> 
>>  Hi Rafael,
>> 
>>  I now get an error when compiling the kernel module (out-of-tree) 
>> with the new PM macros.
>> 
>>  /home/ubuntu/pressure/bmp280-core.c:1163:28: error: expected 
>> ‘)’ before ‘(’ token
>>   1163 |      bmp280_runtime_resume, NULL);
> 
> Which of the macros has triggered this error?

I think the bug was introduced by 23a133c1ba67 ("iio:adc:ab8500: Switch 
from CONFIG_PM guards to pm_ptr() etc")

The macro takes 4 arguments and its first parameter should be the 
dev_pm_ops name, so "ab8500_gpadc_pm_ops".

It slipped during review.

Cheers,
-Paul

> 
>>        |                            ^
>>        |                            )
>>  /home/ubuntu/pressure/bmp280-core.c:1149:12: warning: 
>> ‘bmp280_runtime_resume’ defined but not used [-Wunused-function]
>>   1149 | static int bmp280_runtime_resume(struct device *dev)
>>        |            ^~~~~~~~~~~~~~~~~~~~~
>>  /home/ubuntu/pressure/bmp280-core.c:1141:12: warning: 
>> ‘bmp280_runtime_suspend’ defined but not used [-Wunused-function]
>>   1141 | static int bmp280_runtime_suspend(struct device *dev)
>>        |            ^~~~~~~~~~~~~~~~~~~~~~
>> 
>>  When I revert to the old file without the new PM macros it works 
>> just fine. Do I need to take some extra parameters into account now 
>> with the new format when compiling?
>>