linux-kernel - Re: [PATCH v8 12/19] drm/mediatek: dpi: move the csc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAOTY__3K=2ommcNcfow7kKkOQpL7D0_YuqNBB9rQWjhz7e_DA@mail.gmail.com>
Date:   Mon, 21 Feb 2022 11:33:02 +0800
From:   Chun-Kuang Hu <chunkuang.hu@...nel.org>
To:     Guillaume Ranquet <granquet@...libre.com>
Cc:     Chun-Kuang Hu <chunkuang.hu@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Rob Herring <robh+dt@...nel.org>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Chunfeng Yun <chunfeng.yun@...iatek.com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Vinod Koul <vkoul@...nel.org>, deller@....de,
        CK Hu <ck.hu@...iatek.com>, Jitao Shi <jitao.shi@...iatek.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        DRI Development <dri-devel@...ts.freedesktop.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        DTML <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        linux-phy@...ts.infradead.org, linux-fbdev@...r.kernel.org
Subject: Re: [PATCH v8 12/19] drm/mediatek: dpi: move the csc_enable bit to
 board config

Hi, Guillaume:

Guillaume Ranquet <granquet@...libre.com> 於 2022年2月18日 週五 下午10:56寫道：
>
> Add flexibility by moving the csc_enable bit to board config

After replace 'board' with 'SoC',

Reviewed-by: Chun-Kuang Hu <chunkuang.hu@...nel.org>

>
> Signed-off-by: Guillaume Ranquet <granquet@...libre.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_dpi.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index fcf88dcd8b89d..be99399faf1bb 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -133,6 +133,7 @@ struct mtk_dpi_conf {
>         u32 hvsize_mask;
>         u32 channel_swap_shift;
>         u32 yuv422_en_bit;
> +       u32 csc_enable_bit;
>         const struct mtk_dpi_yc_limit *limit;
>  };
>
> @@ -363,7 +364,8 @@ static void mtk_dpi_config_yuv422_enable(struct mtk_dpi *dpi, bool enable)
>
>  static void mtk_dpi_config_csc_enable(struct mtk_dpi *dpi, bool enable)
>  {
> -       mtk_dpi_mask(dpi, DPI_CON, enable ? CSC_ENABLE : 0, CSC_ENABLE);
> +       mtk_dpi_mask(dpi, DPI_CON, enable ? dpi->conf->csc_enable_bit : 0,
> +                    dpi->conf->csc_enable_bit);
>  }
>
>  static void mtk_dpi_config_swap_input(struct mtk_dpi *dpi, bool enable)
> @@ -827,6 +829,7 @@ static const struct mtk_dpi_conf mt8173_conf = {
>         .hvsize_mask = HSIZE_MASK,
>         .channel_swap_shift = CH_SWAP,
>         .yuv422_en_bit = YUV422_EN,
> +       .csc_enable_bit = CSC_ENABLE,
>         .limit = &mtk_dpi_limit,
>  };
>
> @@ -843,6 +846,7 @@ static const struct mtk_dpi_conf mt2701_conf = {
>         .hvsize_mask = HSIZE_MASK,
>         .channel_swap_shift = CH_SWAP,
>         .yuv422_en_bit = YUV422_EN,
> +       .csc_enable_bit = CSC_ENABLE,
>         .limit = &mtk_dpi_limit,
>  };
>
> @@ -858,6 +862,7 @@ static const struct mtk_dpi_conf mt8183_conf = {
>         .hvsize_mask = HSIZE_MASK,
>         .channel_swap_shift = CH_SWAP,
>         .yuv422_en_bit = YUV422_EN,
> +       .csc_enable_bit = CSC_ENABLE,
>         .limit = &mtk_dpi_limit,
>  };
>
> @@ -873,6 +878,7 @@ static const struct mtk_dpi_conf mt8192_conf = {
>         .hvsize_mask = HSIZE_MASK,
>         .channel_swap_shift = CH_SWAP,
>         .yuv422_en_bit = YUV422_EN,
> +       .csc_enable_bit = CSC_ENABLE,
>         .limit = &mtk_dpi_limit,
>  };
>
> --
> 2.34.1
>