linux-kernel - Re: [PATCH v2] staging: qlge: add unregister_netdev in qlge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220221095623.GB3965@kadam>
Date:   Mon, 21 Feb 2022 12:56:23 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Hangyu Hua <hbh25y@...il.com>
Cc:     manishc@...vell.com, GR-Linux-NIC-Dev@...vell.com,
        coiby.xu@...il.com, gregkh@...uxfoundation.org,
        netdev@...r.kernel.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: qlge: add unregister_netdev in qlge_probe

On Mon, Feb 21, 2022 at 10:23:12AM +0800, Hangyu Hua wrote:
> unregister_netdev need to be called when register_netdev succeeds
> qlge_health_create_reporters fails.
> 
> Signed-off-by: Hangyu Hua <hbh25y@...il.com>
> ---
> 
> v2: use goto to fix this bug

Hey Greg,

Don't take this one.  Take v3 instead with the Fixes tag.

regards,
dan carpenter