linux-kernel - Re: [PATCH] nvmem: qfprom: Increase fuse blow timeout to prevent write fail.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 22 Feb 2022 17:30:11 +0000
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Knox Chiou <knoxchiou@...omium.org>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     Evan Green <evgreen@...omium.org>
Subject: Re: [PATCH] nvmem: qfprom: Increase fuse blow timeout to prevent
 write fail.



On 07/01/2022 02:31, Knox Chiou wrote:
> sc7180 blow fuses got slightly chances to hit qfprom_reg_write timeout.
> Current timeout is simply too low. Since blowing fuses is a
> very rare operation, so the risk associated with overestimating this
> number is low.
> Increase fuse blow timeout from 1ms to 10ms.
> 
> Signed-off-by: Knox Chiou <knoxchiou@...omium.org>

Applied thanks,

--srini
> ---
> 
>   drivers/nvmem/qfprom.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c
> index c500d6235bf6b..1840d400fb53c 100644
> --- a/drivers/nvmem/qfprom.c
> +++ b/drivers/nvmem/qfprom.c
> @@ -22,7 +22,7 @@
>   
>   /* Amount of time required to hold charge to blow fuse in micro-seconds */
>   #define QFPROM_FUSE_BLOW_POLL_US	100
> -#define QFPROM_FUSE_BLOW_TIMEOUT_US	1000
> +#define QFPROM_FUSE_BLOW_TIMEOUT_US	10000
>   
>   #define QFPROM_BLOW_STATUS_OFFSET	0x048
>   #define QFPROM_BLOW_STATUS_BUSY		0x1