linux-kernel - Re: [PATCH v2 04/18] ARM: dts: qcom: disable smb208 regulators for ipq8064-rb3011

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YhUxPigWzLOffcZM@earth.li>
Date:   Tue, 22 Feb 2022 18:53:50 +0000
From:   Jonathan McDowell <noodles@...th.li>
To:     Ansuel Smith <ansuelsmth@...il.com>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 04/18] ARM: dts: qcom: disable smb208 regulators for
 ipq8064-rb3011

On Fri, Feb 18, 2022 at 01:29:42AM +0100, Ansuel Smith wrote:
> Mikrotik RB3011 have a special configuration where the regulators are
> not the common smb208 controlled by RPM but they use a TPS563900
> controlled via i2c. Disable the smb208 for this specific device.
> 
> Signed-off-by: Ansuel Smith <ansuelsmth@...il.com>
> ---
>  arch/arm/boot/dts/qcom-ipq8064-rb3011.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts b/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> index 596d129d4a95..0982b6214fb7 100644
> --- a/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> +++ b/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> @@ -216,6 +216,10 @@ led@7 {
>  	};
>  };
>  
> +&smb208_regulators {
> +	status = "disabled";
> +}

Missing ; after the }, but with that:

Reviewed-by: Jonathan McDowell <noodles@...th.li>
Tested-by: Jonathan McDowell <noodles@...th.li>

> +
>  &adm_dma {
>  	status = "okay";
>  };
> -- 
> 2.34.1
> 

J.

-- 
/-\                             |  Design a system any fool can use,
|@/  Debian GNU/Linux Developer |  and only a fool will want to use
\-                              |                 it.