linux-kernel - Re: [PATCH v2] [hpsa] Fix the wrong chars in comment section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8dc8eb43-b98c-c535-7f9e-a310ccad2a54@linux.alibaba.com>
Date:   Tue, 22 Feb 2022 15:28:00 +0800
From:   James Wang <jnwang@...ux.alibaba.com>
To:     Bart Van Assche <bvanassche@....org>, don.brace@...rosemi.com,
        jejb@...ux.vnet.ibm.com, martin.petersen@...cle.com,
        esc.storagedev@...rosemi.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] [hpsa] Fix the wrong chars in comment section


在 2022/2/16 上午1:37, Bart Van Assche 写道:
> On 2/14/22 17:52, James Wang wrote:
>> These '+' should be redundant.
>>
>> Signed-off-by: James Wang <jnwang@...ux.alibaba.com>
>> Reviewed-by: Bart Van Assche <bvanassche@....org>
>
> Please do NOT add a Reviewed-by tag if a reviewer has not posted that 
> tag himself.
>
> I have the following additional comments on this patch:
> - I am not convinced that this patch is useful since it does not help
>   users of the hpsa driver.

Maybe the patch helps the coding style. ;-)

James.W isn't a expert in storage system,  James.B should be;

but I have to post the issue what I see as a kernel hacker(junior).


> - The comment still does not conform to the Linux kernel coding style.
>   From coding-style.rst:
>
OK; I have run the script to check the code style this patch;

I like to imporve this patch again, without reviewed-by;


James


> The preferred style for long (multi-line) comments is:
>
> .. code-block:: c
>
>     /*
>      * This is the preferred style for multi-line
>      * comments in the Linux kernel source code.
>      * Please use it consistently.
>      *
>      * Description:  A column of asterisks on the left side,
>      * with beginning and ending almost-blank lines.
>      */
>
> Bart.