linux-kernel - Re: [PATCH v2] [hpsa] Fix the wrong chars in comment section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <739e4ca0-ec2d-d39a-4c80-2b2e16435f49@acm.org>
Date:   Tue, 15 Feb 2022 09:37:45 -0800
From:   Bart Van Assche <bvanassche@....org>
To:     James Wang <jnwang@...ux.alibaba.com>, don.brace@...rosemi.com,
        jejb@...ux.vnet.ibm.com, martin.petersen@...cle.com,
        esc.storagedev@...rosemi.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] [hpsa] Fix the wrong chars in comment section

On 2/14/22 17:52, James Wang wrote:
> These '+' should be redundant.
> 
> Signed-off-by: James Wang <jnwang@...ux.alibaba.com>
> Reviewed-by: Bart Van Assche <bvanassche@....org>

Please do NOT add a Reviewed-by tag if a reviewer has not posted that 
tag himself.

I have the following additional comments on this patch:
- I am not convinced that this patch is useful since it does not help
   users of the hpsa driver.
- The comment still does not conform to the Linux kernel coding style.
   From coding-style.rst:

The preferred style for long (multi-line) comments is:

.. code-block:: c

	/*
	 * This is the preferred style for multi-line
	 * comments in the Linux kernel source code.
	 * Please use it consistently.
	 *
	 * Description:  A column of asterisks on the left side,
	 * with beginning and ending almost-blank lines.
	 */

Bart.