linux-kernel - Re: [PATCH v9 02/10] dt-bindings: arm: sunplus: Add bindings for Sunplus SP7021 SoC boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Feb 2022 08:51:33 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     qinjian[覃健] <qinjian@...lus1.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>
Cc:     "mturquette@...libre.com" <mturquette@...libre.com>,
        "sboyd@...nel.org" <sboyd@...nel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "maz@...nel.org" <maz@...nel.org>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "stefan.wahren@...e.com" <stefan.wahren@...e.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        Wells Lu 呂芳騰 <wells.lu@...plus.com>,
        Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v9 02/10] dt-bindings: arm: sunplus: Add bindings for
 Sunplus SP7021 SoC boards

On 22/02/2022 07:15, qinjian[覃健] wrote:
>>> +
>>> +properties:
>>> +  $nodename:
>>> +    const: '/'
>>> +  compatible:
>>> +    oneOf:
>>> +      - items:
>>> +          - const: sunplus,sp7021-achip
>>> +
>>
>> You did not publish DTS so bigger picture and context are missing here.
>> Is it a SoC compatible? A board compatible? Why only one? Against what
>> does it validate?
>>
>> This binding looks incomplete.
> 
> Sunplus SP7021 is an ARM Cortex A7 based SoC.
> The patch is for SP7021 SoC and SP7021 based boards.
> Sorry, I don't understand your questions.
> Could you explain more?

You have there only one compatible but if I would expect at least two.
One for SoC and one for board. Something like this:
Documentation/devicetree/bindings/arm/rda.yaml
but in your case enum would have only one entry.


Best regards,
Krzysztof