linux-kernel - Re: [PATCH v5 03/13] media: atmel: atmel-isc: remove redundant comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 23 Feb 2022 18:06:11 +0100
From:   Jacopo Mondi <jacopo@...ndi.org>
To:     Eugen Hristev <eugen.hristev@...rochip.com>
Cc:     linux-media@...r.kernel.org, hverkuil-cisco@...all.nl,
        nicolas.ferre@...rochip.com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        claudiu.beznea@...rochip.com
Subject: Re: [PATCH v5 03/13] media: atmel: atmel-isc: remove redundant
 comments

Hi Eugen

On Thu, Feb 17, 2022 at 03:56:35PM +0200, Eugen Hristev wrote:
> Remove duplicate comments which are already in place before the struct
> definition.
>
> Signed-off-by: Eugen Hristev <eugen.hristev@...rochip.com>

Reviewed-by: Jacopo Mondi <jacopo@...ndi.org>

Thanks
  j

> ---
>  drivers/media/platform/atmel/atmel-isc.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/atmel/atmel-isc.h b/drivers/media/platform/atmel/atmel-isc.h
> index 07fa6dbf8460..f9ad7ec6bd13 100644
> --- a/drivers/media/platform/atmel/atmel-isc.h
> +++ b/drivers/media/platform/atmel/atmel-isc.h
> @@ -272,7 +272,7 @@ struct isc_device {
>  	struct video_device	video_dev;
>
>  	struct vb2_queue	vb2_vidq;
> -	spinlock_t		dma_queue_lock; /* serialize access to dma queue */
> +	spinlock_t		dma_queue_lock;
>  	struct list_head	dma_queue;
>  	struct isc_buffer	*cur_frm;
>  	unsigned int		sequence;
> @@ -289,8 +289,8 @@ struct isc_device {
>  	struct isc_ctrls	ctrls;
>  	struct work_struct	awb_work;
>
> -	struct mutex		lock; /* serialize access to file operations */
> -	spinlock_t		awb_lock; /* serialize access to DMA buffers from awb work queue */
> +	struct mutex		lock;
> +	spinlock_t		awb_lock;
>
>  	struct regmap_field	*pipeline[ISC_PIPE_LINE_NODE_NUM];
>
> --
> 2.25.1
>