lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20220223170653.z5frqap4wsvi3lsu@uno.localdomain> Date: Wed, 23 Feb 2022 18:06:53 +0100 From: Jacopo Mondi <jacopo@...ndi.org> To: Eugen Hristev <eugen.hristev@...rochip.com> Cc: linux-media@...r.kernel.org, hverkuil-cisco@...all.nl, nicolas.ferre@...rochip.com, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, claudiu.beznea@...rochip.com Subject: Re: [PATCH v5 05/13] media: atmel: atmel-sama5d2-isc: fix wrong mask in YUYV format check Hi Eugen On Thu, Feb 17, 2022 at 03:56:37PM +0200, Eugen Hristev wrote: > While this does not happen in production, this check should be done > versus the mask, as checking with the YCYC value may not include > some bits that may be set. > Is it correct and safe to check the whole mask. > > Fixes: 123aaf816b95 ("media: atmel: atmel-sama5d2-isc: fix YUYV format") > Signed-off-by: Eugen Hristev <eugen.hristev@...rochip.com> I trust this Reviewed-by: Jacopo Mondi <jacopo@...ndi.org> Thanks j > --- > drivers/media/platform/atmel/atmel-sama5d2-isc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/atmel/atmel-sama5d2-isc.c b/drivers/media/platform/atmel/atmel-sama5d2-isc.c > index c244682ea22f..025c3e8a7e95 100644 > --- a/drivers/media/platform/atmel/atmel-sama5d2-isc.c > +++ b/drivers/media/platform/atmel/atmel-sama5d2-isc.c > @@ -291,7 +291,7 @@ static void isc_sama5d2_config_rlp(struct isc_device *isc) > * Thus, if the YCYC mode is selected, replace it with the > * sama5d2-compliant mode which is YYCC . > */ > - if ((rlp_mode & ISC_RLP_CFG_MODE_YCYC) == ISC_RLP_CFG_MODE_YCYC) { > + if ((rlp_mode & ISC_RLP_CFG_MODE_MASK) == ISC_RLP_CFG_MODE_YCYC) { > rlp_mode &= ~ISC_RLP_CFG_MODE_MASK; > rlp_mode |= ISC_RLP_CFG_MODE_YYCC; > } > -- > 2.25.1 >
Powered by blists - more mailing lists