lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 23 Feb 2022 12:12:05 -0500 From: Mimi Zohar <zohar@...ux.ibm.com> To: Stefan Berger <stefanb@...ux.ibm.com>, linux-integrity@...r.kernel.org Cc: serge@...lyn.com, christian.brauner@...ntu.com, containers@...ts.linux.dev, dmitry.kasatkin@...il.com, ebiederm@...ssion.com, krzysztof.struczynski@...wei.com, roberto.sassu@...wei.com, mpeters@...hat.com, lhinds@...hat.com, lsturman@...hat.com, puiterwi@...hat.com, jejb@...ux.ibm.com, jamjoom@...ibm.com, linux-kernel@...r.kernel.org, paul@...l-moore.com, rgb@...hat.com, linux-security-module@...r.kernel.org, jmorris@...ei.org Subject: Re: [PATCH v10 24/27] ima: Introduce securityfs file to activate an IMA namespace On Wed, 2022-02-23 at 12:08 -0500, Stefan Berger wrote: > On 2/23/22 08:54, Mimi Zohar wrote: > > On Tue, 2022-02-01 at 15:37 -0500, Stefan Berger wrote: > > > >> int ima_fs_ns_init(struct user_namespace *user_ns, struct dentry *root) > >> { > >> struct ima_namespace *ns = ima_ns_from_user_ns(user_ns); > >> @@ -531,6 +596,12 @@ int ima_fs_ns_init(struct user_namespace *user_ns, struct dentry *root) > >> } > >> } > >> > >> + if (ns != &init_ima_ns) { > >> + ret = ima_fs_add_ns_files(ima_dir); > >> + if (ret) > >> + goto out; > >> + } > >> + > > In all other cases, the securityfs files are directly created in > > ima_fs_ns_init(). What is different about "active" that a new > > function is defined? > > > It was meant as a function to create namespace-specific files, if more > were to come along. I can move the code from ima_fs_add_ns_files() into > this function if you want. Perhaps defer defining a new function until that happens. thanks, Mimi
Powered by blists - more mailing lists