linux-kernel - Re: [PATCH v1 1/1] misc: bcm-vk: add kconfig for supporting viper chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 23 Feb 2022 08:26:47 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Desmond yan <desmond.yan@...adcom.com>
Cc:     Scott Branden <scott.branden@...adcom.com>,
        Arnd Bergmann <arnd@...db.de>,
        bcm-kernel-feedback-list@...adcom.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] misc: bcm-vk: add kconfig for supporting viper
 chip

On Tue, Feb 22, 2022 at 09:14:02PM -0800, Desmond yan wrote:
> 
> Greg,
> 
> Please see inlined.
> 
> On 2/22/22 09:13, Greg Kroah-Hartman wrote:
> > A: http://en.wikipedia.org/wiki/Top_post
> > Q: Were do I find info about this thing called top-posting?
> > A: Because it messes up the order in which people normally read text.
> > Q: Why is top-posting such a bad thing?
> > A: Top-posting.
> > Q: What is the most annoying thing in e-mail?
> > 
> > A: No.
> > Q: Should I include quotations after my reply?
> > 
> > 
> > http://daringfireball.net/2007/07/on_top
> > 
> > On Tue, Feb 22, 2022 at 07:41:04AM -0800, Desmond Yan (APD) wrote:
> > > Greg,
> > > 
> > > This is to allow the customer to use their own driver, by default,
> > > which is their preferred option.
> > 
> > We do not care about out-of-tree code, and do not add Kconfig options
> > just for that, sorry.
> > 
> > Why not just add the out-of-tree driver here to the in-kernel code?
> > What is preventing that from happening today?
> 
> Using the bcm_vk driver for viper is only for proof-of-concept, and is not
> aimed to be deployed for production.  In parallel, customer is developing
> their own production-ready driver and would probably upstream it whenever
> the appropriate time comes.

Ok, so let us not add a new config option only for one person working on
writing their own driver.  Let's just add the device id as there are
more people than just that one person wanting to use their hardware with
the existing drivers.

Please resubmit this without the Kconfig change and I will be glad to
take it.

thanks,

greg k-h