lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20220223143912.m727fie3vtdkvklo@houat>
Date: Wed, 23 Feb 2022 15:39:12 +0100
From: Maxime Ripard <maxime@...no.tech>
To: Sui Jingfeng <15330273260@....cn>
Cc: Thomas Zimmermann <tzimmermann@...e.de>,
Roland Scheidegger <sroland@...are.com>,
Zack Rusin <zackr@...are.com>,
Christian Gmeiner <christian.gmeiner@...il.com>,
David Airlie <airlied@...ux.ie>,
Daniel Vetter <daniel@...ll.ch>,
Rob Herring <robh+dt@...nel.org>,
Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
Dan Carpenter <dan.carpenter@...cle.com>,
Krzysztof Kozlowski <krzk@...nel.org>,
Andrey Zhizhikin <andrey.zhizhikin@...ca-geosystems.com>,
Sam Ravnborg <sam@...nborg.org>,
"David S . Miller" <davem@...emloft.net>,
Jiaxun Yang <jiaxun.yang@...goat.com>,
Lucas Stach <l.stach@...gutronix.de>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Ilia Mirkin <imirkin@...m.mit.edu>,
Qing Zhang <zhangqing@...ngson.cn>,
suijingfeng <suijingfeng@...ngson.cn>,
linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, dri-devel@...ts.freedesktop.org,
Randy Dunlap <rdunlap@...radead.org>,
kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v10 3/4] drm/lsdc: add drm driver for loongson display
controller
On Tue, Feb 22, 2022 at 10:46:35PM +0800, Sui Jingfeng wrote:
>
> On 2022/2/22 16:27, Maxime Ripard wrote:
> > > + if (!of_device_is_available(output)) {
> > > + of_node_put(output);
> > > + drm_info(ddev, "connector%d is not available\n", index);
> > > + return NULL;
> > > + }
> > > +
> > > + disp_tims_np = of_get_child_by_name(output, "display-timings");
> > > + if (disp_tims_np) {
> > > + lsdc_get_display_timings_from_dtb(output, &lconn->disp_tim);
> > > + lconn->has_disp_tim = true;
> > > + of_node_put(disp_tims_np);
> > > + drm_info(ddev, "Found display timings provided by connector%d\n", index);
> > > + }
> > > +
> > > + connector_type = lsdc_get_connector_type(ddev, output, index);
> > > +
> > > + if (output) {
> > > + of_node_put(output);
> > > + output = NULL;
> > > + }
> > > +
> > > +DT_SKIPED:
> > > +
> > > + /* Only create the i2c channel if display timing is not provided */
> > > + if (!lconn->has_disp_tim) {
> > > + const struct lsdc_chip_desc * const desc = ldev->desc;
> > > +
> > > + if (desc->have_builtin_i2c)
> > > + lconn->ddc = lsdc_create_i2c_chan(ddev, index);
> > > + else
> > > + lconn->ddc = lsdc_get_i2c_adapter(ddev, index);
> > This looks weird: the connector bindings have a property to store the
> > i2c controller connected to the DDC lines, so you should use that
> > instead.
> >
> This is not weird, ast, mgag200, hibmc do the same thing.
And none of them have DT support.
Maxime
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists