linux-kernel - Re: [PATCH v5.1 1/2] ARM: dts: bcm2835-rpi: Move the firmware clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220223144101.543ntapo7iyux27d@houat>
Date:   Wed, 23 Feb 2022 15:41:01 +0100
From:   Maxime Ripard <maxime@...no.tech>
To:     Jean-Michel Hautbois <jeanmichel.hautbois@...asonboard.com>
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-rpi-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com, sbranden@...adcom.com,
        rjui@...adcom.com, f.fainelli@...il.com, nsaenz@...nel.org,
        robh+dt@...nel.org, laurent.pinchart@...asonboard.com,
        stefan.wahren@...e.com, dave.stevenson@...pberrypi.com,
        naush@...pberrypi.com
Subject: Re: [PATCH v5.1 1/2] ARM: dts: bcm2835-rpi: Move the firmware clocks

Hi,

On Wed, Feb 23, 2022 at 03:34:33PM +0100, Jean-Michel Hautbois wrote:
> The bcm2835-rpi.dtsi is used by all Raspberry Pi generations. Move the
> firmware clocks from bcm2711 specific dtsi to the general dtsi.
> 
> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@...asonboard.com>

You're not saying *why* that patch is needed. Change for the sake of
change is usually frowned upon :)

I know you have some reason to do so, but it needs to be in your commit log.

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)