linux-kernel - Re: [EXTERNAL] [PATCH v2] KVM: Don't actually set a request when evicting vCPUs for GFN cache invd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6833a68a9fdf629fcb847b1c4fc1cc815ef85d17.camel@infradead.org>
Date:   Thu, 24 Feb 2022 10:14:24 +0000
From:   David Woodhouse <dwmw2@...radead.org>
To:     Sean Christopherson <seanjc@...gle.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Janosch Frank <frankja@...ux.ibm.com>
Cc:     David Hildenbrand <david@...hat.com>,
        Claudio Imbrenda <imbrenda@...ux.ibm.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [EXTERNAL] [PATCH v2] KVM: Don't actually set a request when
 evicting vCPUs for GFN cache invd

On Wed, 2022-02-23 at 16:53 +0000, Sean Christopherson wrote:
> +       /*
> +        * Request that don't require vCPU action should never be logged in
> +        * vcpu->requests.  The vCPU won't clear the request, so it will stay
> +        * logged indefinitely and prevent the vCPU from entering the guest.
> +        */
> +       BUILD_BUG_ON(!__builtin_constant_p(req) ||
> +                    (req & KVM_REQUEST_NO_ACTION));


Should KVM_REQ_UNHALT be one of these? Might have saved me a number of
hours of debugging the SCHEDOP_poll patch I'm about to repost...


Download attachment "smime.p7s" of type "application/pkcs7-signature" (5965 bytes)