linux-kernel - Re: [PATCH 1/2] scsi: libsas: Make sas_notify_{phy,port}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 24 Feb 2022 13:05:01 +0000
From:   John Garry <john.garry@...wei.com>
To:     Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
        <jejb@...ux.ibm.com>, <martin.petersen@...cle.com>
CC:     <chenxiang66@...ilicon.com>, <linux-scsi@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linuxarm@...wei.com>
Subject: Re: [PATCH 1/2] scsi: libsas: Make sas_notify_{phy,port}_event()
 return void

On 24/02/2022 12:43, Damien Le Moal wrote:
> On 2/24/22 20:04, John Garry wrote:
>> Nobody checks the return codes, so make them return void. Indeed, if the
>> LLDD cannot send an event, nothing much can be done in the LLDD about it.
> 
> It really sound like the LLDDs should be fixed to e.g. reset the adapter
> if things go south with these functions. No sure though.

But this is not an adapter fault. As an example of a scenario which we 
could be dealing with, it may be that a phyup event occurs in the 
adapter but libsas cannot allocate memory to process the event. There's 
not much the adapter/LLDD can do about that (nor does do).

> 
>>
>> Also remove prototype for sas_notify_phy_event() in sas_internal.h, which
>> should not be there.
>>
>> Signed-off-by: John Garry <john.garry@...wei.com>
>> Reviewed-by: Xiang Chen <chenxiang66@...ilicon.com>
> 
> In any case, these changes do not make anything worse :)

Thanks,

> 
> Reviewed-by: Damien Le Moal <damien.lemoal@...nsource.wdc.com>
>