linux-kernel - Re: [PATCH 1/3] pwm-sun4i: convert "next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YheCV0RKJcB/ppCn@orome>
Date:   Thu, 24 Feb 2022 14:04:23 +0100
From:   Thierry Reding <thierry.reding@...il.com>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc:     Max Kellermann <max.kellermann@...il.com>,
        linux-pwm@...r.kernel.org, lee.jones@...aro.org,
        linux-kernel@...r.kernel.org, andrey@...edev.lt,
        stable@...r.kernel.org
Subject: Re: [PATCH 1/3] pwm-sun4i: convert "next_period" to local variable

On Tue, Jan 25, 2022 at 03:31:58PM +0100, Uwe Kleine-König wrote:
> Hello,
> 
> On Tue, Jan 25, 2022 at 01:34:27PM +0100, Max Kellermann wrote:
> > Its value is calculated in sun4i_pwm_apply() and is used only there.
> > 
> > Cc: stable@...r.kernel.org
> 
> I think I'd drop this. This isn't a fix worth on it's own to be
> backported and if this is needed for one of the next patches, the stable
> maintainers will notice themselves (and it might be worth to shuffle
> this series to make the fixes come first).
> 
> > Signed-off-by: Max Kellermann <max.kellermann@...il.com>
> 
> Other than that, LGTM:
> 
> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Does that apply to patches 2 & 3 as well?

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)