linux-kernel - Re: [PATCH] dt-bindings: serial: fsl-lpuart: Add imx93 compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yhj9joQkgTswMVcs@robh.at.kernel.org>
Date:   Fri, 25 Feb 2022 10:02:22 -0600
From:   Rob Herring <robh@...nel.org>
To:     "Peng Fan (OSS)" <peng.fan@....nxp.com>
Cc:     gregkh@...uxfoundation.org, linux-serial@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Peng Fan <peng.fan@....com>
Subject: Re: [PATCH] dt-bindings: serial: fsl-lpuart: Add imx93 compatible
 string

On Tue, Feb 15, 2022 at 04:13:34PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@....com>
> 
> The lpuart on i.MX93 is derived from i.MX8ULP with some industrial
> enhancements, it uses three compatible strings, so update the

Looks like it's 2 compatible strings...

> compatible string for i.MX93. But for a few instants,

s/instants/instances/

> DTR_B, DSR_B, DCD_B and RIN_B pins are supported, so use one compatible
> string fsl,imx93-lpuart-v2

If the differences are just what gets pinned out, then I think the 
differences should be handled with separate properties. We probably 
already have some.

Plus, while you may have all the above signals, a board design may still 
only use a subset.

> 
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---
>  Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> index 6e04e3848261..d7805f31ccc2 100644
> --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> @@ -24,6 +24,8 @@ properties:
>            - fsl,imxrt1050-lpuart
>        - items:
>            - enum:
> +              - fsl,imx93-lpuart
> +              - fsl,imx93-lpuart-v2
>                - fsl,imx8qxp-lpuart
>                - fsl,imx8ulp-lpuart
>            - const: fsl,imx7ulp-lpuart
> -- 
> 2.25.1
> 
>