linux-kernel - Re: [PATCH v5 26/32] mtd: spi-nor: micron-st: rename vendor specific functions and defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 25 Feb 2022 15:38:26 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <michael@...le.cc>
CC:     <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <p.yadav@...com>, <miquel.raynal@...tlin.com>, <richard@....at>,
        <vigneshr@...com>, <yaliang.wang@...driver.com>
Subject: Re: [PATCH v5 26/32] mtd: spi-nor: micron-st: rename vendor specific
 functions and defines

On 2/25/22 17:36, Michael Walle wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Am 2022-02-25 15:03, schrieb Tudor.Ambarus@...rochip.com:
>> On 2/23/22 15:43, Michael Walle wrote:
>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know
>>> the content is safe
>>>
>>> Drop the generic spi_nor prefix for all the micron-st functions.
>>>
>>> Signed-off-by: Michael Walle <michael@...le.cc>
>>> Tested-by: Pratyush Yadav <p.yadav@...com> # on mt35xu512aba,
>>> s28hs512t
>>> ---
>>>  drivers/mtd/spi-nor/micron-st.c | 18 +++++++++---------
>>>  1 file changed, 9 insertions(+), 9 deletions(-)
>>>
>>> diff --git a/drivers/mtd/spi-nor/micron-st.c
>>> b/drivers/mtd/spi-nor/micron-st.c
>>> index 1a7227594bf0..8a20475ce77a 100644
>>> --- a/drivers/mtd/spi-nor/micron-st.c
>>> +++ b/drivers/mtd/spi-nor/micron-st.c
>>
>> you forgot to rename the macros, as you did for xilinx.
> 
> Sigh. Actually, I didn't rename the macros at all (except for xilinx,
> but that was already way before the naming discussion). I couldn't
> come up with a good name, so I just left it as they were.
> 
> TBH, what was just a clean-up for the ready function turned
> into a gigantic patch series and it is very time consuming
> (and frustrating) to respin it just for renaming. We shouldn't
> aim at perfection for patches. Minor details can always be
> fixed later.
> 

Ok. I'll queue the patch set and fix them all in a single patch.