linux-kernel - Re: [PATCH net-next v2 2/3] net: neigh: use kfree_skb_reason() for __neigh_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa952972-7041-26a8-e758-3f2801dff534@kernel.org>
Date:   Fri, 25 Feb 2022 08:39:17 -0700
From:   David Ahern <dsahern@...nel.org>
To:     menglong8.dong@...il.com
Cc:     rostedt@...dmis.org, mingo@...hat.com, davem@...emloft.net,
        kuba@...nel.org, yoshfuji@...ux-ipv6.org, imagedong@...cent.com,
        edumazet@...gle.com, alobakin@...me, cong.wang@...edance.com,
        paulb@...dia.com, talalahmad@...gle.com, keescook@...omium.org,
        ilias.apalodimas@...aro.org, memxor@...il.com,
        flyingpeng@...cent.com, mengensun@...cent.com,
        daniel@...earbox.net, yajun.deng@...ux.dev, roopa@...dia.com,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 2/3] net: neigh: use kfree_skb_reason() for
 __neigh_event_send()

On 2/25/22 12:17 AM, menglong8.dong@...il.com wrote:
> From: Menglong Dong <imagedong@...cent.com>
> 
> Replace kfree_skb() used in __neigh_event_send() with
> kfree_skb_reason(). Following drop reasons are added:
> 
> SKB_DROP_REASON_NEIGH_FAILED
> SKB_DROP_REASON_NEIGH_QUEUEFULL
> SKB_DROP_REASON_NEIGH_DEAD
> 
> The first two reasons above should be the hot path that skb drops
> in neighbour subsystem.
> 
> Reviewed-by: Mengen Sun <mengensun@...cent.com>
> Reviewed-by: Hao Peng <flyingpeng@...cent.com>
> Signed-off-by: Menglong Dong <imagedong@...cent.com>
> ---
> v2:
> - introduce the new drop reason 'SKB_DROP_REASON_NEIGH_DEAD'
> - simplify the document for the new drop reasons
> ---
>  include/linux/skbuff.h     | 5 +++++
>  include/trace/events/skb.h | 3 +++
>  net/core/neighbour.c       | 6 +++---
>  3 files changed, 11 insertions(+), 3 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>