linux-kernel - Re: [PATCH 3/6] staging: r8188eu: cnt is set but not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220226175941.jsizwogfd5wxjm2p@viti.kaiser.cx>
Date:   Sat, 26 Feb 2022 18:59:41 +0100
From:   Martin Kaiser <martin@...ser.cx>
To:     Pavel Skripkin <paskripkin@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Michael Straube <straube.linux@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6] staging: r8188eu: cnt is set but not used

Hi Pavel,

Thus wrote Pavel Skripkin (paskripkin@...il.com):

> Hi Martin,

> On 2/26/22 17:48, Martin Kaiser wrote:
> > In function recv_func, the cnt variable is set but not used.
> > It can be removed.

> > Signed-off-by: Martin Kaiser <martin@...ser.cx>
> > ---
> >   drivers/staging/r8188eu/core/rtw_recv.c | 2 --
> >   1 file changed, 2 deletions(-)

> > diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r8188eu/core/rtw_recv.c
> > index 0144c4642911..9a2e2bc2e294 100644
> > --- a/drivers/staging/r8188eu/core/rtw_recv.c
> > +++ b/drivers/staging/r8188eu/core/rtw_recv.c
> > @@ -1798,11 +1798,9 @@ static int recv_func(struct adapter *padapter, struct recv_frame *rframe)
> >   	if (check_fwstate(mlmepriv, WIFI_STATION_STATE) &&
> >   	    psecuritypriv->busetkipkey) {
> >   		struct recv_frame *pending_frame;
> > -		int cnt = 0;
> >   		pending_frame = rtw_alloc_recvframe(&padapter->recvpriv.uc_swdec_pending_queue);
> >   		while (pending_frame) {

> Just out of curiosity: is this thing infinity loop?

yes it is. And the issue has been present since the driver was first
merged. Let's fix this before removing cnt so that the fix can be
backported to stable. I'll send out v2 shortly.

Thanks,
Martin

> > -			cnt++;
> >   			recv_func_posthandle(padapter, pending_frame);
> >   		}

> Nit: bracers can be removed

> >   	}




> With regards,
> Pavel Skripkin