linux-kernel - Re: [PATCH -next] iio:accel:adxl367: fix missing unlock on error in adxl367_buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 26 Feb 2022 18:08:32 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     "Tanislav, Cosmin" <Cosmin.Tanislav@...log.com>
Cc:     Yang Yingliang <yangyingliang@...wei.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>
Subject: Re: [PATCH -next] iio:accel:adxl367: fix missing unlock on error in
 adxl367_buffer_predisable()

On Thu, 24 Feb 2022 09:38:06 +0000
"Tanislav, Cosmin" <Cosmin.Tanislav@...log.com> wrote:

> Reviewed-by: Cosmin Tanislav <cosmin.tanislav@...log.com>
Sorry. I normally try to pick up the earliest fix when I get
multiple fixes for the same thing but I failed to notice
yours before applying the one Dan sent out!

As a result I've already picked that one up

Thanks for the patch though and I'll check more carefully next
time!

Jonathan

> 
> > -----Original Message-----
> > From: Yang Yingliang <yangyingliang@...wei.com>
> > Sent: Thursday, February 24, 2022 4:03 AM
> > To: linux-kernel@...r.kernel.org; linux-iio@...r.kernel.org
> > Cc: jic23@...nel.org; Tanislav, Cosmin <Cosmin.Tanislav@...log.com>
> > Subject: [PATCH -next] iio:accel:adxl367: fix missing unlock on error in
> > adxl367_buffer_predisable()
> > 
> > [External]
> > 
> > Add the missing unlock before return from function
> > adxl367_buffer_predisable()
> > in the error handling case.
> > 
> > Fixes: cbab791c5e2a ("iio: accel: add ADXL367 driver")
> > Reported-by: Hulk Robot <hulkci@...wei.com>
> > Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> > ---
> >  drivers/iio/accel/adxl367.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iio/accel/adxl367.c b/drivers/iio/accel/adxl367.c
> > index b452d74b1d4d..bdc95409abed 100644
> > --- a/drivers/iio/accel/adxl367.c
> > +++ b/drivers/iio/accel/adxl367.c
> > @@ -1359,7 +1359,7 @@ static int adxl367_buffer_predisable(struct iio_dev
> > *indio_dev)
> > 
> >  	ret = adxl367_set_measure_en(st, true);
> >  	if (ret)
> > -		return ret;
> > +		goto out;
> > 
> >  	ret = adxl367_set_temp_adc_mask_en(st, indio_dev-  
> > >active_scan_mask,  
> >  					   false);
> > --
> > 2.25.1  
>