linux-kernel - Re: [PATCH v2 10/11] fs/drop_caches: move drop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 26 Feb 2022 13:02:19 -0800
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     tangmeng <tangmeng@...ontech.com>
Cc:     viro@...iv.linux.org.uk, akpm@...ux-foundation.org,
        keescook@...omium.org, yzaikin@...gle.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        nizhen@...ontech.com, zhanglianjie@...ontech.com,
        nixiaoming@...wei.com
Subject: Re: [PATCH v2 10/11] fs/drop_caches: move drop_caches sysctls to its
 own file

On Mon, Feb 21, 2022 at 02:10:18PM +0800, tangmeng wrote:
> kernel/sysctl.c is a kitchen sink where everyone leaves their dirty
> dishes, this makes it very difficult to maintain.
> 
> To help with this maintenance let's start by moving sysctls to places
> where they actually belong.  The proc sysctl maintainers do not want to
> know what sysctl knobs you wish to add for your own piece of code, we
> just care about the core logic.
> 
> All filesystem syctls now get reviewed by fs folks. This commit
> follows the commit of fs, move the drop_caches sysctls to its own file,
> fs/drop_caches.c.
> 
> Signed-off-by: tangmeng <tangmeng@...ontech.com>

Thanks but please send a v3 including all the other patches as well
and collecting the Reviewed/Acked-bys, etc. This can be sent *after*
your v3 of the optimization work.

  Luis