linux-kernel - Re: [PATCH 21/29] objtool: Rename --duplicate to --lto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220228201847.x2i5frlmuwprfgap@treble>
Date:   Mon, 28 Feb 2022 12:18:47 -0800
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     x86@...nel.org, joao@...rdrivepizza.com, hjl.tools@...il.com,
        andrew.cooper3@...rix.com, linux-kernel@...r.kernel.org,
        ndesaulniers@...gle.com, keescook@...omium.org,
        samitolvanen@...gle.com, mark.rutland@....com,
        alyssa.milburn@...el.com
Subject: Re: [PATCH 21/29] objtool: Rename --duplicate to --lto

On Mon, Feb 28, 2022 at 09:09:34PM +0100, Peter Zijlstra wrote:
> > So how about we just get rid of the magical --vmlinux and --lto options
> > altogether, and make --noinstr additive, like all the other options?
> >
> >   A) legacy mode:
> >      .o files: objtool check [--module]
> >       vmlinux: N/A
> >        module: N/A
> >
> >   B) CONFIG_NOINSTR_VALIDATION=y && !(CONFIG_X86_KERNEL_IBT=y || CONFIG_LTO=y):
> >      .o files: objtool check [--module]
> >       vmlinux: objtool check --noinstr-only
> >        module: objtool check --module --noinstr-only
> >
> >   C) CONFIG_X86_KERNEL_IBT=y || CONFIG_LTO=y:
> >      .o files: N/A
> >       vmlinux: objtool check --noinstr
> >        module: objtool check --module --noinstr
> 
> I like the --noinstr-only thing. But I think I still like a flag to
> differentiate between TU/.o file and vmlinux/whole-module invocation.

I'm missing why that would still be useful.

> Anyway, you ok with me cleaning this up later, in a separate series?

Sure.  It's already less than ideal today anyway, with '--vmlinux' and
'--duplicate'.

-- 
Josh