linux-kernel - Re: regression: Bug 215601 - gcc segv at startup on ia64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202202281240.8BCFBB47ED@keescook>
Date:   Mon, 28 Feb 2022 12:41:47 -0800
From:   Kees Cook <keescook@...omium.org>
To:     Magnus Groß <magnus.gross@...h-aachen.de>
Cc:     akpm@...ux-foundation.org, anthony.yznaga@...cle.com,
        glaubitz@...sik.fu-berlin.de, linux-fsdevel@...r.kernel.org,
        linux-ia64@...r.kernel.org, linux-kernel@...r.kernel.org,
        matoro_bugzilla_kernel@...oro.tk,
        matoro_mailinglist_kernel@...oro.tk, regressions@...mhuis.info,
        regressions@...ts.linux.dev, viro@...iv.linux.org.uk
Subject: Re: regression: Bug 215601 - gcc segv at startup on ia64

On Mon, Feb 28, 2022 at 11:46:13AM +0100, Magnus Groß wrote:
> > When the kernel tries to map these with a combined allocation, it asks
> > for a giant mmap of the file, but the file is, of course, not at all
> > that large, and the mapping is rejected.
> 
> > So... I'm trying to think about how best to deal with this. If I or
> > anyone else can't think of an elegant solution, I'll send a revert for
> > the offending patch next week.
> 
> Shouldn't we just be able to patch total_mapping_size() again to instead
> sum up all p_memsz fields, instead of comparing minimum and maximum
> p_vaddr?

I don't think so, and I need to have a "minimal change" to fix this so
it's more obviously correct.

And, apologies, I failed to Cc you on this patch:
https://lore.kernel.org/linux-hardening/20220228194613.1149432-1-keescook@chromium.org/

-- 
Kees Cook